kit icon indicating copy to clipboard operation
kit copied to clipboard

Simplify Vite config

Open Rich-Harris opened this issue 2 years ago • 1 comments

Another stepping stone on the way to #7967 (which at this point is less important than the codebase improvements it's driving).

Right now the vite directory is a bit of a mess. The code is full of indirection, and the logic is split up in ways that are quite hard to follow. This simplifies everything.

The vite-plugin-sveltekit-compile plugin should be renamed vite-plugin-sveltekit-serve, though that would break the Storybook integration, which removes that plugin from the array.

Rich-Harris avatar Jan 13 '23 02:01 Rich-Harris

⚠️ No Changeset found

Latest commit: f1ac8468b17692700b9f9feb4156edfef32c718f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 13 '23 02:01 changeset-bot[bot]

Reverted it to a single plugin and moved the define stuff around, even though the code is more confusing now.

I really dislike the concessions we're making here. Something is deeply wrong with how these tools interact with each other. I don't know what the correct solution is, but mutating an array of plugins to remove one that has a specific name is definitely not it.

Rich-Harris avatar Jan 17 '23 22:01 Rich-Harris