kit icon indicating copy to clipboard operation
kit copied to clipboard

feat: provide match function to allow the opposite of resolve

Open hmnd opened this issue 4 months ago • 5 comments

fixes #11746

Delightfully simple to add this as a feature!

Couple things I'm not sure of:

  • The server-side match includes endpoints. Is it more confusing to include them or is it better to exclude to maintain parity with client?
  • generate:types doesn't add match to index.d.ts for some reason. How do I can I get it to work?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

hmnd avatar Nov 27 '25 12:11 hmnd

🦋 Changeset detected

Latest commit: aec93c4b974a5285afbcbc6a77f4791d6034d2bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 27 '25 12:11 changeset-bot[bot]

IMO this would also need to call the reroute hook. Also, we should not duplicate this logic, on the client we could use get_navigation_intent. Something like this:

/**
 * @param {string | URL} url
 */
export async function match(url) {
  if (typeof url === 'string') {
    url = new URL(url, location.href);
  }

  const intent = await get_navigation_intent(url);
  if (intent) {
    return {
      id: intent.id,
      params: intent.params
    };
  }
}

On the server this might be a bit more tricky since this logic is scattered over almost 100 lines.

PatrickG avatar Nov 29 '25 09:11 PatrickG

Preview: https://svelte-dev-git-preview-kit-14997-svelte.vercel.app/

svelte-docs-bot[bot] avatar Dec 09 '25 07:12 svelte-docs-bot[bot]

@PatrickG good call. I switched to that and added support for reroute server-side. Probably easiest to leave server as is rather than trying to abstract it away for this one use case?

Sorry for not looking at this sooner.

hmnd avatar Dec 09 '25 07:12 hmnd

I've extracted the route matching into a new find_route to at least reduce some duplication there :)

hmnd avatar Dec 09 '25 08:12 hmnd