kit fix: correctly detect Cloudflare Workers when either `main` or `assets` key exists

fix: correctly detect Cloudflare Workers when either `main` or `assets` key exists

Open teemingc opened this issue 5 months ago • 2 comments

fixes https://github.com/sveltejs/kit/issues/13832

This PR ensures that if the main key is found in the Wrangler configuration file, that's enough to know that we're building for Cloudflare Workers. Previously, it would continue to check if the assets key exists too. However, the non-existence of the assets key doesn't mean we're building for Cloudflare Pages. It simply means someone has forgotten to add the assets key if they have specified the main key.

~I'd still like to add some unit tests for this so this is not ready yet.~ Added tests

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.