kit icon indicating copy to clipboard operation
kit copied to clipboard

chore: upgrade to cookie 1.0.2

Open Conduitry opened this issue 9 months ago • 22 comments

We've regularly had comments/issues from people about a security vulnerability reported in [email protected], but we've been unable to upgrade because of later versions of the library having stricter validation. It sounds like these restrictions get loosened in 1.0.2 - https://github.com/jshttp/cookie/pull/210 - and so I'm hopeful we can do this upgrade after all. If it turns out that there are still people who are affected by this, we can decide then whether we want to report this upstream to the cookie library or whether we want to deal with this in some other way.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Conduitry avatar Jan 26 '25 18:01 Conduitry