kit icon indicating copy to clipboard operation
kit copied to clipboard

fix: page response missing CSP and Link headers when return promise in `load`

Open 0x221A opened this issue 1 year ago • 1 comments

closes #11801


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

0x221A avatar Jun 29 '24 22:06 0x221A

🦋 Changeset detected

Latest commit: c8eb6825bdab3302bf739c7ce46d2a57305aefd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 29 '24 22:06 changeset-bot[bot]

Would love to see this merged

darg-2036 avatar Jul 27 '24 18:07 darg-2036

Thank you for the PR. I think it's good to merge, but is it possible if we add some kind of test such as one that checks that the CSP headers are included in the server response? Maybe as an additional test in this test suite: https://github.com/sveltejs/kit/blob/6f273fb8a95429c0ff544d4ccd8741c7e1f4ad18/packages/kit/test/apps/options/test/test.js#L115-L139

teemingc avatar Oct 10 '24 04:10 teemingc

@eltigerchino sure!

0x221A avatar Oct 10 '24 06:10 0x221A

Thank you so much!

teemingc avatar Oct 10 '24 06:10 teemingc