kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

fix: use correct cache result when fetching same url multiple times

Open PatrickG opened this issue 1 year ago • 2 comments

Fix #12351

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

PatrickG avatar Jun 15 '24 00:06 PatrickG

🦋 Changeset detected

Latest commit: fca6a7f3b704917ce03a606b112aaf1e0196856f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 15 '24 00:06 changeset-bot[bot]

LGTM but I'd wait for another maintainer that's more familiar with the universal fetch to review this too.

teemingc avatar Jun 16 '24 03:06 teemingc

Preview: https://svelte-dev-git-preview-kit-12355-svelte.vercel.app/

svelte-docs-bot[bot] avatar Aug 12 '25 02:08 svelte-docs-bot[bot]

very late obviously but: I'm good with this solution, I think — we could dedupe repeat requests with identical responses, but given gzip/brotli it probably doesn't save you that much. And given our push for remote functions, it's likely that use of event.fetch will lessen over time, so it's probably not a good use of engineering effort. thank you!

Rich-Harris avatar Aug 12 '25 02:08 Rich-Harris