kit icon indicating copy to clipboard operation
kit copied to clipboard

Enhanced Image: Support {AttributeShorthand} syntax

Open LorisSigrist opened this issue 1 year ago • 1 comments

This PR adds support for the Attribute shorthand syntax on <enhanced:img components. It is now possible to write the following code:

<script>
  import src from "$lib/myImage.png?enhanced"
</script>

<enhanced:img {src} />

Previously this would error

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

LorisSigrist avatar Feb 22 '24 21:02 LorisSigrist

🦋 Changeset detected

Latest commit: e648afeb74dbdea81f0c8f8e85def68596dd4da0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 22 '24 21:02 changeset-bot[bot]

Thank you so much for this! Sorry it took me awhile to get to reviewing it. I'll merge it in just a minute when the CI turns green

benmccann avatar Mar 14 '24 15:03 benmccann