kit icon indicating copy to clipboard operation
kit copied to clipboard

chore: update package description

Open hyunbinseo opened this issue 1 year ago • 1 comments

Since SvelteKit is not mentioned in the package name, description, or tags, the kit package cannot be searched in npmjs.com with the SvelteKit keyword.

image


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

hyunbinseo avatar Feb 14 '24 08:02 hyunbinseo

🦋 Changeset detected

Latest commit: 0353fe2ee0aacba154e67f438dd065dbd3ba804d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 14 '24 08:02 changeset-bot[bot]

Other than the --open flag (which can be reverted if wished - maintainer editing is enabled)

- npm run dev
+ npm run dev -- --open

This PR is basically a one word change in the description. Could this be reviewed and merged?

- The fastest way to build Svelte apps
+ SvelteKit - the fastest way to build Svelte apps

hyunbinseo avatar Jun 13 '24 13:06 hyunbinseo

Thanks for the reminder and for pointing out this issue! I was just playing around with the search on npm and actually don't know if we should change the description either. I think keywords would be a better solution. If that alone isn't enough then maybe we can update the description. I sent https://github.com/sveltejs/kit/pull/12330 as an attempt to fix this. I'll leave this open while we evaluate whether it's enough

benmccann avatar Jun 13 '24 14:06 benmccann

@sveltejs/kit is now searchable using the SvelteKit keyword.

image

hyunbinseo avatar Jun 19 '24 01:06 hyunbinseo

great! too bad it's only the fourth result. I'll merge this to see if it helps boost it up the rankings

benmccann avatar Jun 19 '24 03:06 benmccann