kit icon indicating copy to clipboard operation
kit copied to clipboard

Allow any numeric value for BODY_SIZE_LIMIT in adapter-node

Open Rich-Harris opened this issue 1 year ago • 1 comments

Describe the problem

From #11381 — it's unlikely but conceivable that someone would want to set a body size limit of zero. More to the point, it's arguably a bit weird that '0' actually means 'Infinity'.

It's also reasonable that someone would want to do something like BODY_SIZE_LIMIT=1e6 to express 'a megabyte'.

Describe the proposed solution

Allow any numeric JavaScript value, using parseFloat. Error if this results in NaN.

Rich-Harris avatar Jan 10 '24 14:01 Rich-Harris

ok let me take a look

codenoid avatar Jan 10 '24 17:01 codenoid

closed via #11589

Rich-Harris avatar Jan 11 '24 02:01 Rich-Harris