kit icon indicating copy to clipboard operation
kit copied to clipboard

fix: remove scrollbars on default error page

Open jaylinski opened this issue 1 year ago • 2 comments

Description

The CSS rule body { height: 100vh } on the default error-page will cause vertical scrollbars if the default body-margin isn't removed.

I didn't include a changelog because it is such a minor change. (But I can add one if you want.)

How to test

Open @sveltejs/kit/src/core/config/default-error.html and verify that there are no vertical scrollbars.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

jaylinski avatar May 30 '23 10:05 jaylinski

🦋 Changeset detected

Latest commit: 4725ab015f0d34ab34324592101eb867bdb7c184

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 30 '23 10:05 changeset-bot[bot]

@benmccann Thanks for adding the changeset :raised_hands:

jaylinski avatar May 30 '23 16:05 jaylinski