svelte-add icon indicating copy to clipboard operation
svelte-add copied to clipboard

Added bun support

Open ThatXliner opened this issue 1 year ago • 2 comments
trafficstars

ThatXliner avatar Jan 22 '24 22:01 ThatXliner

Hey @ThatXliner were you able to test this? Windows does not want to install WSL correctly. From the other source code, it look like there might be other places that might need to be adjusted to make this work.

manuel3108 avatar Feb 16 '24 14:02 manuel3108

Hey @ThatXliner were you able to test this? Windows does not want to install WSL correctly. From the other source code, it look like there might be other places that might need to be adjusted to make this work.

I have not tested this yet, and I didn’t know about the other places that may need this change.

ThatXliner avatar Feb 16 '24 15:02 ThatXliner

@manuel3108 @ThatXliner

It's not required to use WSL anymore. Bun is compatible with windows now

To install bun in windows, go to https://bun.sh ant it seays how to install it with powershell

Command outputs:

$ bun --version
1.1.0
$ bun install
bun install v1.1.0 (5903a614)

Checked 6 installs across 7 packages (no changes) [10.00ms]
$ bun create svelte

create-svelte version 6.0.10

┌  Welcome to SvelteKit!
│
■  Where should we create your project?
│

RubenPX avatar Apr 04 '24 03:04 RubenPX

@RubenPX Thanks for your help in identifying this.

svelte-add will be deprecated pretty soon, so it doesn't make sense to implement the changes here. I have already opened an issue in it's successor project svelte-compose

manuel3108 avatar Apr 05 '24 11:04 manuel3108

@manuel3108 Understand this package will soon be deprecated. It would be great to sneak #333 in before you do that, given that svelte-add is used in many places and will still be depended on for a while.

Electroid avatar Apr 09 '24 00:04 Electroid

Your PR is more comprehensive than mine. I'll close this one ig. I didn't have time to update it so

ThatXliner avatar Apr 09 '24 01:04 ThatXliner