Add layout elements for the new XY-Grid component

[jeromelebleu]

Foundation v6.4 introduces a new XY-Grid component, see here.

This adds the GridX, GridY and Cell elements with only basics classes. Should I also add a GridContainer class to handle the Grid Container?

Thanks in advance - and for your work by the way!

[sveetch]

Ah, i was afraid this moment someone will ask about GridXY because i'm not a huge fan about this component so i totally dropped out my mind :)

But i can't refuse it, the only thing i need it's a test to validate it so i can reasonably keep it without to be broken on future changes. I recommend you to follow the development doc then add your own as something like "006_grid.py", copying and adapting this test to your layout object would be enough, then i will review it before merging it and document it.

For the grid container, i can't really say since i don't use gridXY, but it seems useful no? I may say first finish the test for what you already did, think about it and open up a new dedicated PR.

[jeromelebleu]

Ah, i was afraid this moment someone will ask about GridXY because i'm not a huge fan about this component so i totally dropped out my mind :)

Oops, sorry to be that guy... :) Out of curiosity, what do you not like in this component?

But i can't refuse it, the only thing i need it's a test to validate it so i can reasonably keep it without to be broken on future changes. [...]

No problem, I will work on that. This PR was more a starting point to discuss it, get your feedbacks and to know how to code that. Thanks for your recommendations, I will try to add some tests first so!

[ghost]

I was pretty certain I would not like the GridXY - but I now love it. Simplicity.

I would love to see it added. The best I can do now is something crazy like:

Div ( 
    Div ( 'email', css_class = 'large-8 large-offset-2 cell' ),
    css_class = 'grid-x'
    ),

I think XY is here to stay and am now a fan. So this would be a very welcome addition for me.

thanks for the great work.

[sveetch]

I would need some help on this, since i need some tests to validate GridXY support and for now i don't have time to study gridxy references.

[jeromelebleu]

I have finally not used crispy forms in my application... nor crispy-forms-foundation. As I don't plan to use it soon, I will not be able to help you in adding tests - and ensure that it works! - sorry about that.

[ghost]

I would be happy to help, but I am not a professional coder.

I think if we just turned a DIV into a GRID and a Column into a Cell you would be 80% there.

I personally don’t need the “Y” and think that is where all the stress would come from. And who would ever need the Y-axis for a form?

I will take a look at your code and see if some “elbow grease” can overcome the “intellectual” part.

cheers.

On Nov 8, 2017, at 6:22 PM, David THENON [email protected] wrote:

I would need some help on this, since i need some tests to validate GridXY support and for now i don't have time to study gridxy references.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sveetch/crispy-forms-foundation/pull/35#issuecomment-342788699, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2eRnw4CQ7cuj8i2N6PVp3Q0mb8zEw3ks5s0Y7agaJpZM4OrgTv.

thomas wm. benson | student of humanity & citizen of the world | [email protected] | +1. 239 . 206 . 3240

“Government is not a solution to our problem - government is the problem.” - Ronald Reagan

[jeromelebleu]

I would be happy to help, but I am not a professional coder.

Feel free to ask, if I can help you! And don't worry, you don't have to be a professional coder... My only issue is that I will not use it...

[ghost]

There is a new issue with Django 2.0.

Exception Value: not enough values to unpack (expected 2, got 0)

{% if not field|is_checkbox and not field|is_checkboxselectmultiple %} {% crispy_field field %} {% endif %}

https://stackoverflow.com/questions/47689875/django-2-0-multiselect-issue?noredirect=1#comment82340474_47689875 https://stackoverflow.com/questions/47689875/django-2-0-multiselect-issue?noredirect=1#comment82340474_47689875

I will let you know if a can find a solution. Always happy to help.

On Nov 14, 2017, at 3:12 AM, jeromelebleu [email protected] wrote:

I would be happy to help, but I am not a professional coder.

Feel free to ask, if I can help you! And don't worry, you don't have to be a professional coder... My only issue is that I will not use it...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sveetch/crispy-forms-foundation/pull/35#issuecomment-344043084, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2eRnMbQiv6OVnTgHoUhZMssRC9EhNiks5s2KKfgaJpZM4OrgTv.

thomas wm. benson | student of humanity & citizen of the world | [email protected] | +1. 239 . 206 . 3240

“Government is not a solution to our problem - government is the problem.” - Ronald Reagan

[mpasternak]

@sveetch I'm pretty new to Foundation 6, but basically "row" becomes "grid-x" or "grid-x grid-margin-x" if you want spaces and "columns" becomes "cell". "large-N", "small-N", "medium-N" classes stay the same.

This upgrade (to GridXY) is required, because everything else becomes obsolete in the grid dept with the next foundation release. But, I assure you, there's nothing to be afraid of. At least it looks like it.

[sveetch]

No problemo, the only thing required is to add gridXY support as an alternative, float grid still be basic way from Foundation<7, and that according unittest is added and run nicely.

[ryancausey]

What needs to be done to this PR, besides fixing merge conflicts, in order for it to be merged?

Or, is there another plan in the works to add XY Grid support?

[sveetch]

@ryancausey it lacks of unit tests on added layout elements.