Changes

added new wasm mod for supporting get and set API for wasi target.
get method for hostname will always returns static string wasihost - https://github.com/WebAssembly/wasi-libc/issues/196#issuecomment-620933143
set method for hostname is emulated

Dec 22 '21 13:12 mdrokz

Hi, @mdrokz , thank you for your PR!

Yet, I do not understand the purpose of those changes: it does not returns actual hostname (due to linkage issue you mentioned) and set() function is a stub. How can it be useful for crate users?

Jan 05 '22 10:01 svartalf

Hi, @mdrokz , thank you for your PR!

Yet, I do not understand the purpose of those changes: it does not returns actual hostname (due to linkage issue you mentioned) and set() function is a stub. How can it be useful for crate users?

Hi, this just adds support for wasm target there are lot of crates that depend on this one, for example the lettre and lettre_email crate if i want to compile lettre for wasm then the compilation would fail because this crate doesnt support wasm target.

Jan 07 '22 09:01 mdrokz

Hey!

I'm not sure if that is the approach I want to follow: if some particular target is not supported, I personally would prefer to learn about that fact during the compilation.

I can imagine it will be very confusing to figure out in runtime why returned value is very different from the actual system hostname. Even returning some blank error like std::io::Error with std::io::ErrorKind::Unsupported all the time might not fit all use cases.

On the other hand, with compilation failure each of the crate consumers can choose what approach to use: not provide support for this target at all or use some "default" value instead with conditional compilation like in the following pseudo-code (sorry, writing from my head, might have some naive mistakes):

#[cfg(any(target_family="unix", target_family="windows"))]
use hostname::get as get_hostname;

#[cfg(not(any(target_family="unix", target_family="windows")))]
fn get_hostname() -> io::Result<OsString> {
    "unknown".into()
}

Anyway, so far I'm inclined not to accept this PR, but I'm open for further discussion, of course, and having a wasm support would also be great.

Jan 10 '22 16:01 svartalf

Support compilation to wasm target

Changes