Svante Schubert

Results 122 comments of Svante Schubert

You are absolutely right, Todd. OdfElement has the base functionality to concatenate the text content: https://github.com/tdf/odftoolkit/blob/master/odfdom/src/main/java/org/odftoolkit/odfdom/pkg/OdfElement.java#L2633 but the every text node containing element like OdfTextSpan should override this method and...

The ODF specification explains in the bullet list of 6.1.1 all elements containing text that should not be considered, see https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#a_6_1_Basic_Text_Content The funcationality is currently spread and needs to harmonized,...

@brlin-tw "OdfWhitespaceParser" might be a relic from the "Simple API", which was abandoned due to design issues. I was not able to refactor the API due to the heavily copied...

BTW, sometimes it is not that easy: When you ask for the text content of a paragraph, there might be an image part of that paragraph - its image data...

PS: Michael just pointed out the following chapter of the spec, which is of interest for our task at hand: _6.1.1 General The paragraph elements text:p and text:h and their...

@brlin-tw Would it be possible if you could share your solution as a patch? I just ran into the same problem, where the line breaks of a pretty-printing of a...

PS: If there are two places where whitespace handling takes place, we should identify them and consider a merge, but those implementations might be working on different models like SAX...

Tests/Assertions have been disabled due to this issue and should be enabled again with the fixing patch: Search for "229" in the following files to find these spots: * https://github.com/svanteschubert/odftoolkit/blob/FormatCodeTests/odfdom/src/test/java/org/odftoolkit/odfdom/doc/table/TableCellTest.java#L212...

Nice catch! Thank you! Do you have some simplified test document to reproduce the issue? Most welcome would be a patch of yours where there is a test involved that...

@pnemonic78 How are we able to reproduce this issue? We need some more data to fix this! Thanks in advance!