node2nix icon indicating copy to clipboard operation
node2nix copied to clipboard

New release

Open mkg20001 opened this issue 3 years ago • 4 comments

Would it be possible to create a new release to include the latest fixes in nixpkgs or is there anything blocking that?

mkg20001 avatar Nov 14 '21 13:11 mkg20001

I'm close to it. The only thing that is "blocking" the release is my investigation of patching the bin/ executables after running npm rebuild. I'm still investigating what the impact of that would be and if it doesn't make things worse.

If you want to help, try to find packages that rely on rebuilding and see if the deployments still work acceptably.

svanderburg avatar Nov 14 '21 14:11 svanderburg

Usually packages that deliver bindings have the source code for whatever they're trying to build shipped with them and optionally fetch prebuilt assets at build time

Meaning if there's no internet connection - like during the drv build - the rebuild will fallback to building binaries regularly, meaning they will work out-of-the-box on nixOS

I never really had a case where that didn't work

mkg20001 avatar Nov 14 '21 14:11 mkg20001

I'm almost ready. Tomorrow I'll run some final checks, then publish a new release and then work on updating Nixpkgs.

svanderburg avatar Nov 16 '21 23:11 svanderburg

I've now started on a PR to update Nixpkgs with newly generated expressions: https://github.com/NixOS/nixpkgs/pull/146440

svanderburg avatar Nov 17 '21 22:11 svanderburg