jQPlot icon indicating copy to clipboard operation
jQPlot copied to clipboard

Published 20 hours ago • verified publisher icon svandecappelle

revert the jslint merge commits erros

Open svandecappelle opened this issue 9 years ago • 3 comments

Lots of commits causes regressions on functionalities:

  • core
  • dateAxis
  • shadows

svandecappelle avatar Jan 11 '16 09:01 svandecappelle

What kind of issues are you experiencing? I made sure that all visible examples and tests still ran, so I'm really curious what kind of issues you found.

johanbove avatar Jan 11 '16 11:01 johanbove

The check intersection method is returned a first series loop. In fact all hover or check intersection events concerning the series index > 1 did not fired any events. See what I changed: https://github.com/svandecappelle/jQPlot/blob/83c9d184d9f2826551d0d027f57cddd487b29408/src/core/jqplot.core.js#L693

Function return was called after each 'case' statement. Wich caused the loop always break after first serie.

An exemple of the issue: donut chart -> Hover your mouse on a slice. There is no highlight color. The jqplot github pages are already patched with the new version.

svandecappelle avatar Jan 12 '16 14:01 svandecappelle

I'm sorry the "code cleanup" resulted in these issues. I thought it would be good to make the code more readable and following linting rules. Did you create a test for this issue?

johanbove avatar Mar 21 '16 16:03 johanbove