valet icon indicating copy to clipboard operation
valet copied to clipboard

feat: implement steward-ward pattern for schedule and dispatch goroutines

Open svaloumas opened this issue 2 years ago • 1 comments

  • Adds Scheduler.NewSteward method
  • Turns Scheduler.Dispatch and Scheduler.Schedule methods to wards
  • Refactors WorkService.Dispatch method

svaloumas avatar Nov 25 '22 16:11 svaloumas

Codecov Report

Base: 76.73% // Head: 75.74% // Decreases project coverage by -0.99% :warning:

Coverage data is based on head (9ed3ebc) compared to base (732aec4). Patch coverage: 59.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   76.73%   75.74%   -1.00%     
==========================================
  Files          32       32              
  Lines        3271     3360      +89     
==========================================
+ Hits         2510     2545      +35     
- Misses        538      593      +55     
+ Partials      223      222       -1     
Flag Coverage Δ
unittests 75.74% <59.77%> (-1.00%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/core/service/worksrv/service.go 84.87% <29.72%> (-5.23%) :arrow_down:
internal/core/service/schedulersrv/service.go 68.27% <65.67%> (-27.11%) :arrow_down:
valet.go 92.30% <100.00%> (+0.64%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Nov 25 '22 16:11 codecov[bot]