Sami Vaarala
Sami Vaarala
Re: forcing `DUK_F_INTELSGX` from outside, there are existing platforms where automatic detection is not possible and an external define is used to force detection, see for example https://github.com/svaarala/duktape/blob/master/config/helper-snippets/DUK_F_AMIGAOS.h.in (for VBCC)....
I'll try to review the diff tomorrow night, assuming it is ready for comments.
@hf I finally got some time to do a review on the changes. Mostly just trivia but there's one probable snprintf() truncation issue and AUTHORS needs a fix. With these...
> @svaarala Thanks for reviewing. I tried to get all indent issues, but not sure how I missed these. Maybe think about setting up clang-format to get rid of issues...
Adding a `.editorconfig` sounds good to me. I'll steer clear of debating tabs vs spaces ;-)
I'll take a look - after that commits should be squashed for merging (a single commit is fine).
@hf Went through the changes and there's just some minor trivia left, see review comments. Once you address them, you can just squash the commits into one, and I'll then...
You might be thinking of asm.js - webassembly provides a binary bytecode format, a Javascript API for it, etc.
See http://webassembly.org/: > The wasm stack machine is designed to be encoded in a size- and load-time-efficient binary format. There's a textual format, but it's for debugging etc (http://webassembly.org/docs/text-format/), example:...
It's not for JS, but a pretty different language - it's best explained by looking at the bytecode format and what operations it supports.