virtualization-rs icon indicating copy to clipboard operation
virtualization-rs copied to clipboard

Published 20 hours ago • verified publisher icon suzusuzu

fix: Use StrongPtr::retain on class methods

Open siketyan opened this issue 2 years ago • 2 comments

Resolves #4

I am not good at Objective-C and/or macOS things, so I do not know this is the correct resolution of this issue. However I confirmed this works without occurring any segmentation faults.

siketyan avatar Apr 02 '23 06:04 siketyan

Thanks for the bug fix. However, we would appreciate it if you could wait for a while to merge this fix. We would probably prefer to eliminate the autorelease object and solve everything with runtime::objc_release by Drop Trait.

suzusuzu avatar Apr 11 '23 01:04 suzusuzu

@suzusuzu Thank you for the investigation. If this pull request resolves the issue not in a good way, feel free to close and supersede it. Thank you.

siketyan avatar Apr 11 '23 01:04 siketyan