github-comment
github-comment copied to clipboard
feat: add update-condition for github-comment exec
Check List
- [x] Read OSS Contribution Guide
- [x] Write a GitHub Issue before creating a Pull Request
- Link to the issue:
- [x] All commits are signed
- This repository enables
Require signed commits, so all commits must be signed
- This repository enables
- [x] Avoid force push
- [x] Do only one thing in one Pull Request
I have added --update-conditon to exec sub-command so that existing comments can be overwritten. post implementation as a reference (PR: https://github.com/suzuki-shunsuke/github-comment/issues/473)
related:
- https://github.com/suzuki-shunsuke/github-comment/discussions/972
- https://github.com/suzuki-shunsuke/github-comment/issues/473
🤔
Error: pkg/api/exec.go:217:1: calculated cyclomatic complexity for function getComment is 11, max is 10 (cyclop)
func (c *ExecController) getComment(execConfigs []*config.ExecConfig, cmtParams *ExecCommentParams, templates map[string]string) (*github.Comment, bool, error) { //nolint:funlen
@suzuki-shunsuke What do you think? We are using github-comment exec heavily in many repositories on work, so I want to use this feature.
Sorry, I'll take a look this weekend. Honestly, I'm not a fan of updating comments, but I understand that this feature is necessary for some users like you.