github-comment icon indicating copy to clipboard operation
github-comment copied to clipboard

feat: add update-condition for github-comment exec

Open ponkio-o opened this issue 11 months ago • 3 comments

Check List

I have added --update-conditon to exec sub-command so that existing comments can be overwritten. post implementation as a reference (PR: https://github.com/suzuki-shunsuke/github-comment/issues/473)

related:

  • https://github.com/suzuki-shunsuke/github-comment/discussions/972
  • https://github.com/suzuki-shunsuke/github-comment/issues/473

ponkio-o avatar Jan 03 '25 06:01 ponkio-o

🤔

Error: pkg/api/exec.go:217:1: calculated cyclomatic complexity for function getComment is 11, max is 10 (cyclop)
func (c *ExecController) getComment(execConfigs []*config.ExecConfig, cmtParams *ExecCommentParams, templates map[string]string) (*github.Comment, bool, error) { //nolint:funlen

ponkio-o avatar Jan 03 '25 06:01 ponkio-o

@suzuki-shunsuke What do you think? We are using github-comment exec heavily in many repositories on work, so I want to use this feature.

ponkio-o avatar Jan 09 '25 08:01 ponkio-o

Sorry, I'll take a look this weekend. Honestly, I'm not a fan of updating comments, but I understand that this feature is necessary for some users like you.

suzuki-shunsuke avatar Jan 09 '25 12:01 suzuki-shunsuke