Suyash Kumar comments

Results 146 comments of


                                            Suyash Kumar

Parsing OB/OW element of undefined length fails and temporarily allocates 4GB of memory

@patrickwhite256 thank you for the deep dive into this, really helpful! My initial take is to _not_ follow pydicom's behavior. To me it makes more sense to hold the raw...

Parsing OB/OW element of undefined length fails and temporarily allocates 4GB of memory

We might be able to do something like the below. Though I wonder if we should be concatenating allData into a single byte slice if there are multiple items. OB's...

Parsing OB/OW element of undefined length fails and temporarily allocates 4GB of memory

Fantastic, sounds great! Feel free to put up / update the PR if you have time! (If not, let me know, and happy to help).

Update JSON output to follow PS3.18 Annex F

Hi there! The JSON representation in this library was initially designed for debug output (it's pretty tied to the Go representations/structures), but I think it's very reasonable to make it...

feat(parser): support transfer syntax inference when parsing small DICOM fragments (<100 bytes)

Thanks for the contribution! Out of curiosity, is there some reason why the auto-detection doesn't work? https://github.com/suyashkumar/dicom/blob/0fbaef53037ef4c533a9e6004dfc5b7b224ecc39/parse.go#L179-L180 Or is the idea to make this behavior more explicit?

feat(parser): support transfer syntax inference when parsing small DICOM fragments (<100 bytes)

Makes sense! First off, I think adding an option if needed is totally reasonable. Out of curiosity, I'd like to see if we can make it work without an option...