Erki Suurjaak comments

Results 59 comments of


                                            Erki Suurjaak

Caching media files.

Sorry for the delay, finally got around to releasing v5.4. Added configuration flag `SharedContentUseCache` for this, by default false.

Caching media files.

Confirmed. In fact, they haven't worked since 5.3, I now discover.

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

As a fix, I would simply remove this raising (https://github.com/ros2/rclpy/blob/master/rclpy/rclpy/time.py#L106) and instead return `NotImplemented` if the given argument is not an instance of `Time`. Ditto for `Duration`. There is a...

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

@fujitatomoya ping?

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

How does the current code make sense? It is a perfectly valid operation to compare any Python object for equality with any other Python object. Current code logic breaks standard...

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

@sloretz Any input on this?

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

@jacobperron @fujitatomoya How about that pull request?

rclpy.time.Time and rclpy.duration.Duration raise error on comparing to None

@jacobperron @fujitatomoya @sloretz How about that pull request: https://github.com/ros2/rclpy/pull/1007 ?

Fix Time and Duration raising exception when compared to another type

@fujitatomoya @sloretz ping on this?

Fix Time and Duration raising exception when compared to another type

> This is a behavior change, and I don't think we should do that in the already released distributions. I would say that this is a bugfix, and as such...