Crashes with wayland on fedora 28

[tommy-engels]

I realized since fedora 25 or so (since wayland became the default), that your fantastic extension does unfortunately have severe problems when running in wayland mode. It causes crashes of the gnome-shell, which is, even more unfortunate, acting as a display server. thus, if it crashes, all applications go down with the gnome shell. (see, e.g. https://superuser.com/questions/1164174/how-can-i-restart-the-gnome-shell-on-wayland). I am currently using fedora 28 with gnome 3.28.2

one bug I was able to pin-point is when the system is suspended while being in the overview mode. after resume, I cannot leave the overview mode anymore, nor select any application. so a restart is required.

now the obvious workaround is running under X.org, but the development focus of gnome appears to be wayland. that implies in the long run, new features may not be available under X.org. On my machine (a Dell XPS15 2017 9560), I have a 4k monitor and wayland is much more reactive and convenient.

However, the gnome shell without your extension is almost useless, since it is very hard to find the window I am looking for. Myself I am not a gui developer so I have no clue how to solve this issue, but I hope there's a possibility to restore the wayland support.

[sustmi]

The issue should be fixed by 67bdded32ecf1619d052cecb00598efe0817e557 and dc1b6124d959c360e03af4b83f2d17f00921b3bf. Can you confirm it does not crash any more?

Note that the fixes are present in v32 of the extension which was not reviewed yet: https://extensions.gnome.org/extension/302/windowoverlay-icons/ . However if you know how, you can try the code in master.