kepler icon indicating copy to clipboard operation
kepler copied to clipboard

Possible wrong spelling on variable name

Open williamcaban opened this issue 3 years ago • 1 comments

It looks to me the NODE_ENERGY_STAT_METRRIC = "node_energy_stat" on line29 https://github.com/sustainable-computing-io/kepler/blob/5d4f4e93c8a28c2e21244ea1dfa4817affc7bb44/pkg/collector/collector.go#L29 might be spelling error.

Can anyone confirm? The same spelling is also used on the following files:

https://github.com/sustainable-computing-io/kepler/blob/424d2f88d2c050a354c023e8b830afefd312baf4/pkg/collector/collector.go#L123

https://github.com/sustainable-computing-io/kepler/blob/fb8af8c979516e4015b2dbebef88d1896e613e03/pkg/collector/collector_test.go#L133

williamcaban avatar Sep 11 '22 18:09 williamcaban

@williamcaban nice code reading! PR welcome

rootfs avatar Sep 11 '22 21:09 rootfs

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 17 '23 18:05 stale[bot]

@williamcaban can you create a PR for this?

marceloamaral avatar May 18 '23 05:05 marceloamaral

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 21 '23 03:08 stale[bot]