kepler icon indicating copy to clipboard operation
kepler copied to clipboard

Use make targets instead of docker actions for building and pushing images on CI

Open vprashar2929 opened this issue 1 year ago • 2 comments

What would you like to be added?

A GH workflow responsible for building and pushing images of Kepler using make targets.

Why is this needed?

Currently, we use pre-defined actions for building and pushing images for Kepler to quay. In certain situations where images are not built or pushed correctly, it is very hard to investigate the issue.

Using our existing make targets for building and pushing images has the advantage that it's running the same "make" steps as a developer would run, so less risk of things working differently in CI from in development.

vprashar2929 avatar Apr 17 '24 11:04 vprashar2929

in this case, how we ensure multi-arch images support?

SamYuan1990 avatar Apr 17 '24 11:04 SamYuan1990

Parametrize the arch in the makefile e.g., make image ARCH=arm64. Then just use a matrix in the action to build for all supported arch values.

4censord avatar Jun 14 '24 21:06 4censord