kepler-operator icon indicating copy to clipboard operation
kepler-operator copied to clipboard

chore: update must-gather to support power-monitor

Open vprashar2929 opened this issue 8 months ago • 1 comments

This commit updates the must-gather script to also gather power-monitor related information. It refactors the existing gather script to include support for both Kepler and PowerMonitor making sure that the gather script is compatible with both instance types

vprashar2929 avatar Apr 25 '25 13:04 vprashar2929

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.68%. Comparing base (dcb4c64) to head (c100fb5). Report is 41 commits behind head on v1alpha1.

Additional details and impacted files
@@            Coverage Diff            @@
##           v1alpha1     #477   +/-   ##
=========================================
  Coverage     28.68%   28.68%           
=========================================
  Files            21       21           
  Lines          1820     1820           
=========================================
  Hits            522      522           
  Misses         1287     1287           
  Partials         11       11           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 25 '25 13:04 codecov[bot]

Implementation looks good. I still need to perform manual validation on openshift local.

KaiyiLiu1234 avatar Apr 29 '25 03:04 KaiyiLiu1234

@vprashar2929 Tested on Openshift cluster and everything works well. must-gather runs without error. must-gather directory contains power-monitor related events, kubernetes objects yaml, relevant logs from power-monitor deployed pod(s). My only concern is that power-monitor-info./ebpf-info, power-monitor-info./kernel-ebpf-features, and power-monitor-info./node-cpuid-info are empty. I think ideally for power-monitor-info these should just be removed as i assume these logs are more for original kepler. This will be up to your discretion.

KaiyiLiu1234 avatar May 06 '25 05:05 KaiyiLiu1234

Yeah I agree. My thinking is that once we remove Kepler(old) will remove everything we capture related to that.

vprashar2929 avatar May 06 '25 06:05 vprashar2929

That sounds good to me!

KaiyiLiu1234 avatar May 06 '25 11:05 KaiyiLiu1234

Yeah I agree. My thinking is that once we remove Kepler(old) will remove everything we capture related to that.

@vprashar2929 could you please add a tracker issue for this?

Merging the PR based on @KaiyiLiu1234 's comment.

sthaha avatar May 07 '25 01:05 sthaha