react-annotation icon indicating copy to clipboard operation
react-annotation copied to clipboard

TypeScript support

Open martpie opened this issue 7 years ago • 3 comments

Hello 👋

Have you considered adding TypeScript typings to react-annotation? :)

martpie avatar Sep 13 '18 08:09 martpie

I'm not sure how much work that would be, I don't use TypeScript myself. Some contributors helped me add it to d3-annotation. Would love any help on this front.

susielu avatar Sep 13 '18 23:09 susielu

Would you accept Pull Requests on this repo, or should I try to add them at Definitely Typed?

martpie avatar Sep 14 '18 08:09 martpie

A pull request would be great!

On Fri, Sep 14, 2018, 1:16 AM Pierre de la Martinière < [email protected]> wrote:

Would you accept Pull Requests on this repo, or should I try to add them at https://github.com/DefinitelyTyped/DefinitelyTyped?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/susielu/react-annotation/issues/16#issuecomment-421269063, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYfbUHx9kN686aL-cU1MpON_t4Nfecoks5ua2XngaJpZM4WmzM8 .

susielu avatar Sep 14 '18 15:09 susielu