trident

trident copied to clipboard

sarangparikh22

Decrease cost of the swap function by ~ 1200 gas by removing an unnecessary BentoBox balanceOf call.

gasperbr

sarangparikh22

accross -> across

eltociear

integrate solmate STL, and reduce mloads

z0r0z

Cp patch

1

gasperbr

Can existing implementation be supported?

7flash

https://github.com/sushiswap/trident/blob/ef1f4ed9de50325c8f84edd90aecfafbcfe31ee5/contracts/pool/concentrated/ConcentratedLiquidityPool.sol#L561-L566 When calculating feeGrowth, currentTick must be calculated based on the current price for it to be calculated correctly. * AS-IS ````solidity int24 currentTick = nearestTick; ```` * TO-BE ````solidity...

theKata

ConcentratedLiquidityPoolManager Allowance Check Issue

2

referenced : `ConcentratedLiquidityPoolManager.sol` Is there any reason why it is possible to call only `msg.sender`? ````solidity require(msg.sender == ownerOf(tokenId), "NOT_ID_OWNER"); ```` If this happens, it will be difficult to create...

theKata

ConcentratedLiquidityPool ensureTickSpacing logic issue

1

when the value of `lower` is `TickMath.MIN_TICK` and `upper` is `TickMath.MAX_TICK`, I think it should be passed `_ensureTickSpacing()` method. But current `_ensureTickSpacing()` block this case. My Suggestion is below. ###...

theKata