Puppy icon indicating copy to clipboard operation
Puppy copied to clipboard

Is this intentionally internal?

Open adam-rocska opened this issue 1 year ago • 0 comments

https://github.com/sushichop/Puppy/blob/510741ffa55e364a991ba1243266c05a9f7a15c6/Sources/Puppy/FileRotationLogger.swift#L13

Hey,

I've been implementing a nice Codable extension to some of Puppy's stuff to eliminate a bunch of boilerplate from our server-side swift project.

Apparently the referenced code is internal, and I've been boggled the whole day whether it's a design decision or just hapaned to be that way?

Of-course, if the answer is the latter, if you don't mind I would love to open a PR to open that field to the public... should be safe.... it's a let and it's a minor change, non-breaking

adam-rocska avatar Nov 10 '23 18:11 adam-rocska