surrealdb.py icon indicating copy to clipboard operation
surrealdb.py copied to clipboard

Fix 'merge' in ws.py

Open chrda81 opened this issue 1 year ago • 4 comments

Response message "Method not found" is received with error_code "SurrealPermissionException", so I guess the method="change" is obsolete.

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Type of Change

  • [ ] 📚 Examples / docs / tutorials / dependencies update
  • [x] 🔧 Bug fix (non-breaking change which fixes an issue)
  • [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
  • [ ] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🔐 Security fix

What does this change do?

This change fixes the 'merge' function.

What is your testing strategy?

Is this related to any issues?

Have you read the Contributing Guidelines?

chrda81 avatar Dec 26 '23 23:12 chrda81

~~I encountered the same problem when using Surreal.patch. Would you mind checking all methods, and extending this fix for them all?~~ ~~I guess same PR is fine :shrug:~~

Wouterkoorn avatar Apr 01 '24 21:04 Wouterkoorn

I encountered the same problem when using Surreal.patch. Would you mind checking all methods, and extending this fix for them all?~ ~I guess same PR is fine 🤷

I see now that the whole patch method is wrong, and more changes are needed than just changing the method name. I will create separate issue/PR - apologies for the spam

Wouterkoorn avatar Apr 01 '24 22:04 Wouterkoorn

any updates on this? i'm getting surrealdb.ws.SurrealPermissionException: Method not found for .merge and it's been outstanding issue for the python SDK for years.

starascendin avatar Aug 09 '24 18:08 starascendin

Still not done. Neither patch method seems to be found.

igoutta avatar Sep 03 '24 16:09 igoutta