Better-Envato icon indicating copy to clipboard operation
Better-Envato copied to clipboard

Published 20 hours ago • verified publisher icon surjithctly

Migration to chrome.storage API and 24 hour currency rate caching

Open zGerden opened this issue 9 years ago • 10 comments

Title says it all :)

zGerden avatar Mar 14 '15 21:03 zGerden

Hey Zan, Thanks for putting this together, Did you test it?

Anyway, I will also do a quick round of testing and will merge tomorrow...

surjithctly avatar Mar 15 '15 07:03 surjithctly

Hello, Yes I tested it, but it wouldn't be bad if currency rate caching would been tested for a little longer. Also, when you merge, please don't create new version, as I have to fix one issue before.

zGerden avatar Mar 15 '15 16:03 zGerden

Okay. You can update the pull request..

surjithctly avatar Mar 15 '15 16:03 surjithctly

OK, I fixed it.

zGerden avatar Mar 16 '15 05:03 zGerden

Hello, I tested it for few days and noticed only that settings weren't saved, but it all works now.

zGerden avatar Mar 23 '15 20:03 zGerden

Great.. I've been busy these weeks, Will push an update soon.

surjithctly avatar Mar 24 '15 04:03 surjithctly

One more thing I found that, The conversion from localstorage to storage api is too slow and stopping when I clicked options page. So, Few of the localstorage items stays there and some in the storage API. I need to click reload quite few times to make it convert fully.

Do you have any idea why this is happening?

surjithctly avatar Mar 24 '15 06:03 surjithctly

@zan-gerden got my message?

surjithctly avatar Mar 26 '15 06:03 surjithctly

Yes I did, but currently I don't have much time and will fix this maybe next week.

zGerden avatar Mar 26 '15 16:03 zGerden

Sure, Tight schedule for all of us. :)

surjithctly avatar Mar 26 '15 17:03 surjithctly