surge icon indicating copy to clipboard operation
surge copied to clipboard

Clicking Text Boxes does not change focus / Can't enter text

Open jpf91 opened this issue 1 year ago • 6 comments

Bug Description: For some reason, the text boxes in the Patch browser do not get focus most of the time when clicked and it's not possible to enter text.

Surge XT Version

  • Version: 1.2.3, binary RPM from releases page
  • Plugin Type: VST3 (happens in LV2 and CLAP as well)
  • Bitness:64-bit

Reproduction Steps: Steps to reproduce the behavior:

  1. Start Reaper
  2. Create a new project
  3. Insert virtual instrument on new track
  4. VST3i/Surge XT (Also happens with LV2 or CLAP)
  5. Surge XT Window opens. Press Save in Patch browser
  6. Try to type, does not work (Screenshot 1)
  7. Click on Templates Text (Screenshot 2)
  8. Text is shaded, but cursor does not move to other box. Only exactly during the click, the cursor blinks once
  9. Sometimes the focus does move, not really reproducible
  10. Once there is focus in one of the boxes, typing is possible. TAB key then reliably changes focus between boxes and typing into any box with active focus works. All boxes however still have the text shaded most of the time, sometimes the background clears. (Screenshot 3)

Expected Behavior: Text should only be shaded if it is selected. Clicking a text box should move focus to the box and typing into the box should work.

Screenshots: Bildschirmfoto vom 2023-08-19 17-08-37 Bildschirmfoto vom 2023-08-19 17-10-10 Bildschirmfoto vom 2023-08-19 17-12-51

Computer Information (please complete the following!):

  • OS: Linux, completely updated Fedora 38
  • Host: Reaper
  • Version: 6.81
  • Happens using both X11 and Wayland

jpf91 avatar Aug 19 '23 15:08 jpf91

Regarding shading, this seems to be a JUCE behavior. Every text entry field is showing its selected state (you can see when text field is not focused with cursor in it, it's a bit more transparent)...

mkruselj avatar Aug 19 '23 18:08 mkruselj

I can confirm same bug using Carla Rack. Clicking on the title bar activates the "real" focus and I'm able to write text (when saving a preset), but the search dropdown has no titlebar, so it is not possible to use it (it works for the first time, sometimes few times more, but then, I'm not able to get the focus on a search text input).

marcin-koziol avatar Aug 23 '23 11:08 marcin-koziol

It happens to me too on Archlinux/Wayland. It also happens with Vital (so I guess it's realted to Juce, especially given that vanilla Surge is not affected). Makes my life a nightmare, especially to save presets, as I sometime have to spam clicks for up to one minute before being able to get the text box focus to write something. From what I recall from playing around with Juce, text entries on linux were quite broken, and sometimes switching to wayland or even switching Destkop Environnements can create issues (I stopped using Hyprland for this reason, because an update broken some input related features). I'm suprised I'm not finding more issues as it seems to happen on 3 different computers I tried.

QuentinFAIDIDE avatar Feb 06 '24 05:02 QuentinFAIDIDE

Text shading in every text box (this is indeed JUCE remembering selection per text editor widget, then just applying 50% opacity to it) should be eradicated in the latest nightly. Does this fix the issue for y'all?

mkruselj avatar Feb 06 '24 06:02 mkruselj

Capture vidéo du 2024-02-06 10-10-14.webm

Here is a screen recording of me messing with text entries on a main branch build (you can see I literally just built it). Either I picked the wrong version (are nightly builds the main branch?), or either it is not fixed. The few fix releases from JUCE above the version currently shipped in Surge does not seem to integrate any fix related to text entries on Linux/Wayland. Maybe it would be a good idea to escalate the issue to them and look into producing a fix there. It currently affects many VSTs as I was saying.

QuentinFAIDIDE avatar Feb 06 '24 08:02 QuentinFAIDIDE

Huh yeah that's definitely not how it's supposed to work. Feel free to raise it with JUCE, I don't think we can do anything regarding this on our end...

mkruselj avatar Feb 06 '24 08:02 mkruselj