stochas icon indicating copy to clipboard operation
stochas copied to clipboard

Create new 32-bit and 64-bit windows installers

Open mthierman opened this issue 3 years ago • 8 comments

mthierman avatar Jun 13 '22 18:06 mthierman

Great!

Will azure run these or are they purely additive and we need to set up pipelines?

baconpaul avatar Jun 14 '22 12:06 baconpaul

I think if we replace line 165 where we run ISCC:

iscc //Obuild\\product //Fstochas_windows_installer //DSTOCHAS_VERSION=${STOCHAS_VERSION}.${GH} "install\\win\\install.iss"

with something like this:

iscc //Obuild\\product //Fstochas_windows_installer64 //DMyAppVersion=${STOCHAS_VERSION}.${GH} //DSTOCHAS_SRC="..\..\" //DSTOCHAS_BIN="..\..\build" "install\\win\\stochas64.iss"
iscc //Obuild\\product //Fstochas_windows_installer32 //DMyAppVersion=${STOCHAS_VERSION}.${GH} //DSTOCHAS_SRC="..\..\" //DSTOCHAS_BIN="..\..\build32" "install\\win\\stochas32.iss"

This should build 32 and 64 bit installers instead. And should publish with the existing windows task since that publishes the whole build/product folder already, if I'm understanding that task properly.

mthierman avatar Jun 14 '22 20:06 mthierman

I should also check what happens when I run this over an old install in case we need a cleanup task or something

Edit: So the old installer already leaves a mess if you install standalone after VST3 (it forces two installation processes).

The new installers use different locations and create a different entry in add/remove programs. I am not sure if we should add an InstallDelete section

mthierman avatar Jun 14 '22 20:06 mthierman

I've revisited this and don't think we should delete files from an existing install, so I think we either merge this or keep the original 32bit/64 bit install and possibly update that instead. Thoughts?

mthierman avatar Jul 26 '22 01:07 mthierman

Any reason to not clean up the prior install? It’s not user data right just installed assets?

i should do the signed mac installer stuff here too like we do for the other properties. I’ll peek at that this week

oh and I should fix that zoom thing and turn in clap builds!

baconpaul avatar Jul 26 '22 01:07 baconpaul

If we delete the files it still leaves an entry in add/remove programs (since it's different GUID)

mthierman avatar Jul 26 '22 01:07 mthierman

Can you whack the registry in the new install script? (Shudder)

baconpaul avatar Jul 26 '22 01:07 baconpaul

I added a PowerShell script to plumb the registry and run any previous uninstaller, should work on 32bit and 64bit Windows.

mthierman avatar Aug 05 '22 00:08 mthierman