AEG Envelope regression: Decay appears to be broken

[djtuBIG-MaliceX]

When modifying the AEG values for a single zone, the following issues are evident:

• If both Attack and Hold values are 0, the Decay phase is never 'run' which causes the zone playback to loop indefinitely until note off to trigger Release. That is:

  • If (A+H) > 0, D runs
  • If (A + H) == 0, D doesn't run at all.

• Decay value scaling issue - what is reportedly 1.12s seems to sound more like 0.25s, and the slider is about halfway on the UI.

• If modifying this in a multi-zone selection, there appears to be a crash scenario (difficult to reproduce).

REPRODUCE

1. Load any WAV file into the Zone mapping view
2. On AEG, set zone Attack and Hold to 0, Decay to anything, Sustain to 0
3. Play a note.
4. Set Attack OR Hold to any other value.
5. Play a note.
6. Repeat.

Evident on build @ commit 114ea16

https://github.com/user-attachments/assets/ee6a1caa-fd13-4683-a8f6-f8c10184efb5