Diff Overview Bar no longer has the theme applied

[benjaminmillhouse]

Describe the bug The Diff Overview bar on the right no longer reflects the theme I have selected for the editor. ("vs-dark" in this case) From what I can tell, this started occurring after v4.5.

(v4.4.6)

(v4.5.2)

To Reproduce Render a DiffEditor as "vs-dark" theme

Expected behavior I expect the styling of the diff overview bar to match the editor (dark background).

[benjaminmillhouse]

FYI - I'm not sure if this is ultimately a monico-editor issue, or specific to this react plugin... but I think the issue has to do with changing to a variable-based application of the style theme.

If I add a definition for --vscode-editor-background to the root of my styling (:root { } via CSS), then the bar renders correctly. Perhaps something is causing that new variable to not be scoped correctly to the Overlay elements? Or defined too far down in the tree?

Adding the following snippet to my CSS:

Appears to fix the issue:

[benjaminmillhouse]

Sorry for the mass-updates... this does appear to be an issue with the core Monaco-editor project...

https://github.com/microsoft/monaco-editor/issues/4051

[github-actions[bot]]

This issue has been marked as stale due to inactivity. It will be closed in 7 days unless further activity occurs.

[github-actions[bot]]

Closing due to inactivity. Feel free to reopen if needed.