monaco-react icon indicating copy to clipboard operation
monaco-react copied to clipboard

Models persist after unmount Editor when use multi model editor

Open FrancoJavierGadea opened this issue 2 years ago • 3 comments

Describe the bug When a Editor is unmounting dispose only the current model. In multi model editors shoud be dispose all model associates to the Editor

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/multi-model-editor-forked-zz347j?file=/src/App.js
  2. Click on files buttons
  3. Click on Simulate unmount
  4. See error, how models persist after unmount the editor

https://codesandbox.io/s/multi-model-editor-forked-zz347j?file=/src/App.js

FrancoJavierGadea avatar Jun 08 '23 23:06 FrancoJavierGadea

Has there been any progress on this issue?

zbqsfs avatar Jun 14 '24 01:06 zbqsfs

Not only creating models, but using "setValue" repeatly can cause leakage also.

benjenpoetry avatar Oct 11 '24 03:10 benjenpoetry

Hey, any progress on this?

dylantientcheu avatar Jan 28 '25 15:01 dylantientcheu

This issue has been marked as stale due to inactivity. It will be closed in 7 days unless further activity occurs.

github-actions[bot] avatar Jul 28 '25 00:07 github-actions[bot]

Closing due to inactivity. Feel free to reopen if needed.

github-actions[bot] avatar Aug 04 '25 00:08 github-actions[bot]