Matthew Cramerus

Results 10 comments of Matthew Cramerus

Re: > I seriously doubt it can fit in a normal int, so perhaps that has something to do with the compiled version freezing and giving incorrect results. If I...

I compiled the code with `--single-thread` as you said, and I ran it as many times as I could in 10 minutes with arguments of varying size. As far as...

@alamb @NGA-TRAN Thanks for the swift action - I guess I'll go ahead and mark this as ready for review since it's being reviewed, haha. I'm still planning to add...

@NGA-TRAN I added a sqllogictest and fixed some bugs in the implementation. CI [seems to be passing now](https://github.com/polygon-io/arrow-datafusion/actions/runs/8370873137)

@alamb I won't be able to get to this until tomorrow, just letting you know

I'm not sure why changing a comment caused the tests to start failing.... oof.

@alamb I added a config value, and I moved `MinMaxStatistics` to its own module as requested. I wasn't sure if I should delay addressing your feedback on tests to the...

@alamb Just to be absolutely clear, if the plan consists entirely of Parquet files from a single table, then the `SortPreservingMerge` will be eliminated. As you can see in [this...

I have had a somewhat overlapping (no pun intended) issue where DataFusion abandons the `SortPreservingMergeStream` and does a global sort if there are multiple files in any file groups. It...

Sorry @alamb @mustafasrepo, I completely missed this. My GH notifications tend to get drowned out by stuff from work, but I've discovered my personal email doesn't have this issue. I...