supertokens-python
supertokens-python copied to clipboard
fix: remove normalise_url_path_or_throw_error unnecessary lowercasing
Summary of change
This PR aims to fix the issue by removing lower method from normalise_url_path_or_throw_error function
Related issues
https://github.com/supertokens/supertokens-python/issues/537
Test Plan
I have tested and verified this change by adding custom thirdparty integration for Cisco Duo which has case sensitive URL for OIDC Discovery Endpoint
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
- [ ] Changelog has been updated
- [ ]
coreDriverInterfaceSupported.jsonfile has been updated (if needed)- Along with the associated array in
supertokens_python/constants.py
- Along with the associated array in
- [ ]
frontendDriverInterfaceSupported.jsonfile has been updated (if needed) - [ ] Changes to the version if needed
- In
setup.py - In
supertokens_python/constants.py
- In
- [ ] Had installed and ran the pre-commit hook
- [ ] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (
git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag. - If no such branch exists, then create one from the latest released branch.
- To know which one it is, run find the latest released tag (
- [ ] If have added a new web framework, update the
supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariable - [ ] If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
- [ ] Make sure that
syncio/asynciofunctions are consistent. - [ ] If access token structure has changed
- Modified test in
tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the core
- Modified test in
Remaining TODOs for this PR
- [ ] Item1
- [ ] Item2