supertokens-python icon indicating copy to clipboard operation
supertokens-python copied to clipboard

Auto transpiling to catchup to node sdk (as of 19.0 branch of node sdk)

Open rishabhpoddar opened this issue 1 year ago • 0 comments

Summary of change

TODO

Related issues

TODO

Test Plan

TODO

Documentation changes

TODO

Checklist for important updates

  • [ ] Changelog has been updated
  • [ ] coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • [ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
  • [ ] Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • [ ] Had installed and ran the pre-commit hook
  • [ ] Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • [ ] If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • [ ] If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • [ ] Make sure that syncio / asyncio functions are consistent.
  • [ ] If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core
  • [ ] Check that functions like list user by account info etc have been added to root async / syncio or not (basically check for any missing functions)
  • [ ] Check that st-t-dmns claim is not added by default in the session access token

Remaining TODOs for this PR

  • [x] Make use of AccountLinkingUser instead of User in all places in the SDK.
  • [x] SessionContainer implementation needs to take recipe_id as an input arg as opposed to auto assigning it to user_id
  • [ ] In user_get api in dashboard:
    • [ ] Check implementation of get_search_params_from_url is correct
    • [x] Remove mock of users oldest / newest get
  • [x] Remove mock_get_user from dashboard/utils.py
  • [x] Add the TOTP and MFA related checks in supertokens.init (thats commented out at the moment)
  • [ ] Make sure Literal is only imported from type_extension and not types
  • [x] in account linking recipe, in verify_email_for_recipe_user_if_linked_accounts_are_verified, we need to pass attempt_account_linking=False when calling verify_email_using_token
  • [x] Call to revoke_all_sessions_for_user in emailverification.recipe should uncomment the false
  • [ ] check everywhere for use of RecipeUserId(...) and make sure we are not just passing in user_id in it
  • [x] change the auto linking part of sessions if an access token is present in the request

Recipes

  • [x] accountlinking
  • [x] mfa
  • [x] dashboard
  • [x] third party providers changes
  • [x] emailpassword
  • [x] emailverification
  • [x] jwt
  • [x] multitenancy
  • [x] openid
  • [x] passwordless
  • [x] session
  • [x] thirdparty
  • [x] usermetadata
  • [x] userroles
  • [x] totp

rishabhpoddar avatar Jul 21 '24 10:07 rishabhpoddar