supertokens-node
supertokens-node copied to clipboard
[WIP] feat: skip field validations on non signup routes
Summary of change
From my understanding of the ticket, we wanted to avoid doing field validations on form fields for non-signup routes, since it is field validation that emits FORM_FIELD errors. This would mean we would be delegating the validation to the core, for say email and password. Please feel free to let me know if this is not the intended change of the ticket and if it is to be done differently. I am quite new to the repo so my understanding is quite limited. I am happy to do it the right way with little guidance. Thank you for your time and patience.
Related issues
- https://github.com/supertokens/supertokens-node/issues/447
- https://github.com/supertokens/supertokens-auth-react/issues/638
Test Plan
I have yet to run the test cases and update them if necessary, will do it once I get a go on the implementation
Documentation changes
This might need a Docs update as mentioned in the ticket.
Checklist for important updates
- [x] Changelog has been updated
- [x] Changes to the version if needed
- In
package.json - In
package-lock.json - In
lib/ts/version.ts
- In
- [x] Had run
npm run build-pretty - [x] Had installed and ran the pre-commit hook
- [ ] Issue this PR against the latest non-released version branch.
- To know which one it is, run find the latest released tag (
git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag. - If no such branch exists, then create one from the latest released branch.
- To know which one it is, run find the latest released tag (
Remaining TODOs for this PR
- [ ] Get clarification on the approach
- [ ] Maybe update types where necessary (Need some guidance on this part as well)
Deploy Preview for astounding-pegasus-21c111 canceled.
| Name | Link |
|---|---|
| Latest commit | dab7d0c73cda5e51712d5a734abc4574361f90ab |
| Latest deploy log | https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/66d2f6114dbf87000899bcf9 |
Deploy Preview for precious-marshmallow-968a81 canceled.
| Name | Link |
|---|---|
| Latest commit | dab7d0c73cda5e51712d5a734abc4574361f90ab |
| Latest deploy log | https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/66d2f61164767f0008251026 |
Hey @akashrajum7 thanks for this PR. Whilst it makes sense, i won't be merging it right now, since this requires changes to our frontend sdk types and docs for which, we don't yet have the bandwidth.
Hey @akashrajum7 thanks for this PR. Whilst it makes sense, i won't be merging it right now, since this requires changes to our frontend sdk types and docs for which, we don't yet have the bandwidth.
Thanks for the review, sure, let me see if I can find some time this week to both update the test cases for these changes as well as make those changes in the frontend sdk