supertokens-node icon indicating copy to clipboard operation
supertokens-node copied to clipboard

Removing combination recipe (base PR)

Open rishabhpoddar opened this issue 1 year ago • 2 comments

Related issues

  • https://github.com/supertokens/supertokens-node/issues/815

Test Plan

  • [x] Changes to test to use separate recipes in all tests that had them as combination.

Checklist for important updates

  • [ ] Changelog has been updated
  • [ ] coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • [ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
  • [ ] Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • [ ] Had run npm run build-pretty
  • [ ] Had installed and ran the pre-commit hook
  • [ ] If new thirdparty provider is added,
    • [ ] update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • [ ] add an icon on the user management dashboard.
  • [ ] Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • [ ] If have added a new web framework, update the add-ts-no-check.js file to include that
  • [ ] If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • [ ] If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • [ ] Search for all places for thirdpartyemailpassword and thirdpartypasswordless and make sure they don't exist
  • [ ] Test dashboard
  • [x] if input rid is tpep, or tpless, it should try and map to the the right breakup
  • [x] Add test for checking rid based on tpep and tpless
  • [x] remove rid from links generated by the sdk

rishabhpoddar avatar Apr 04 '24 11:04 rishabhpoddar

Hey @ellipsis, give me a code review

rishabhpoddar avatar Apr 11 '24 09:04 rishabhpoddar

Hey @ellipsis, give me a code review

rishabhpoddar avatar Apr 11 '24 10:04 rishabhpoddar