supertokens-node icon indicating copy to clipboard operation
supertokens-node copied to clipboard

feat: library structulibrary structural changeral change

Open productdevbook opened this issue 2 years ago • 3 comments

close #413 close #459 close #360 close #299

It includes major structural changes.

  • [x] tsup build system
  • [x] fix ts export paths again
  • [x] eslint support
  • [x] esm support
  • [x] all dependencies update
  • [x] test vitest change and ts convert
  • [ ] TS 4.9 support
  • [ ] TS 5.0 support
  • [ ] npm dist check. Check if they came out with the old structure exactly the same
  • [x] pnpm 8.0.0 upgrade
  • [ ] ... soon

Test Errors INSTALL_PATH=../supertokens-root pnpm test

  • [ ] thirdpartypasswordless/recipeFunctions
  • [ ] thirdpartypasswordless/provider
  • [ ] thirdpartypasswordless/smsDelivery
  • [ ] userroles/config
  • [ ] thirdparty/override
  • [ ] thirdparty/provider

productdevbook avatar Mar 04 '23 09:03 productdevbook

upgrade "typescript": "^4.9.5" and pnpm build


recipe/emailverification/emailVerificationClaim.ts(48,3): error TS2612: Property 'validators' will overwrite the base property in 'BooleanClaim'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

If someone who is an expert on this issue solves the problem and sends me a pr, let's merge it here.

productdevbook avatar Mar 04 '23 13:03 productdevbook

I waited for someone to fix 6 test errors, I wrote from discord, but no one came. So good luck with your project.

productdevbook avatar May 10 '23 05:05 productdevbook

Apologies for not getting back sooner. We are quite busy with new feature releases.

About this PR, I think someone from our team was communicating with you earlier (on our discord). But due to the nature and size of the PR, we put that on hold.

If you can reduce the size of the PR or break it into smaller chunks, we would be happy to have a look.

rishabhpoddar avatar May 10 '23 05:05 rishabhpoddar