supertokens-golang icon indicating copy to clipboard operation
supertokens-golang copied to clipboard

Removes combination recipe (base pr)

Open rishabhpoddar opened this issue 1 year ago • 0 comments

Related issues

  • https://github.com/supertokens/supertokens-node/issues/815

Test Plan

  • [ ] Changes to test to use separate recipes in all tests that had them as combination.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • [ ] Changelog has been updated
  • [ ] coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • [ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
  • [ ] Changes to the version if needed
    • In supertokens/constants.go > version variable
  • [ ] Had installed and ran the pre-commit hook
  • [ ] If new thirdparty provider is added,
    • [ ] update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • [ ] add an icon on the user management dashboard.
  • [ ] Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • [ ] If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • [ ] Search for all places for thirdpartyemailpassword and thirdpartypasswordless and make sure they don't exist
  • [ ] Test dashboard
  • [ ] if input rid is tpep, or tpless, it should try and map to the the right breakup
  • [ ] Add test for checking rid based on tpep and tpless
  • [ ] remove rid from links generated by the sdk
  • [ ] Dashboard API for chaning user password needs to be tested (userPasswordPut)

rishabhpoddar avatar Apr 09 '24 05:04 rishabhpoddar