memphis icon indicating copy to clipboard operation
memphis copied to clipboard

Ability to set infinite retention

Open yanivbh1 opened this issue 2 years ago • 12 comments

yanivbh1 avatar Apr 03 '23 06:04 yanivbh1

Hi, guys! I would like to work on this problem, if you don't mind

ZakharE avatar May 04 '23 19:05 ZakharE

Great to have you here @ZakharE ! Adding @idanasulinmemphis

yanivbh1 avatar May 04 '23 22:05 yanivbh1

Hi @ZakharE, great you can go for it

idanasulin2706 avatar May 07 '23 12:05 idanasulin2706

Hi @idanasulinmemphis I think, i've done with it Please, check out #917 Looking forward for a feedback

ZakharE avatar May 09 '23 08:05 ZakharE

Hey @idanasulinmemphis @ZakharE, What is our status?

yanivbh1 avatar Jul 17 '23 20:07 yanivbh1

Hi! Sorry, I can't no longer work on this issue. I'll close the PR

ZakharE avatar Jul 23 '23 13:07 ZakharE

Hi @yanivbh1 @idanasulinmemphis, I like to give this a go.

Big-Vi avatar Jul 24 '23 05:07 Big-Vi

Hey @Big-Vi , would like to work on it?

yanivbh1 avatar Aug 10 '23 05:08 yanivbh1

Hi @idanasulinmemphis,

I like to clarify this.

https://github.com/memphisdev/memphis/pull/917#issuecomment-1546877424 In this comment, you mentioned setting stream limit to -1 in order to apply no limit. But MaxAge value expecting time.Duration type. https://github.com/memphisdev/memphis/blob/master/server/memphis_helper.go#L242C6-L242C6

Can we set this MaxAge to time.Duration(math.MaxInt64) which provides a value of 292 years.

Big-Vi avatar Aug 11 '23 10:08 Big-Vi

@Big-Vi May I suggest a different task? Since you are an expert in Schemaverse, what do you think about making more progress there? For example: https://github.com/memphisdev/memphis/issues/879 (Huge impact) https://github.com/memphisdev/memphis/issues/723 https://github.com/memphisdev/memphis/issues/485

yanivbh1 avatar Aug 12 '23 08:08 yanivbh1

@yanivbh1 I can pick one and work on it.

Big-Vi avatar Aug 13 '23 10:08 Big-Vi

Hey @Big-Vi , #879 would be a huge win.

yanivbh1 avatar Aug 13 '23 11:08 yanivbh1