memphis
memphis copied to clipboard
Ability to set infinite retention
Hi, guys! I would like to work on this problem, if you don't mind
Great to have you here @ZakharE ! Adding @idanasulinmemphis
Hi @ZakharE, great you can go for it
Hi @idanasulinmemphis I think, i've done with it Please, check out #917 Looking forward for a feedback
Hey @idanasulinmemphis @ZakharE, What is our status?
Hi! Sorry, I can't no longer work on this issue. I'll close the PR
Hi @yanivbh1 @idanasulinmemphis, I like to give this a go.
Hey @Big-Vi , would like to work on it?
Hi @idanasulinmemphis,
I like to clarify this.
https://github.com/memphisdev/memphis/pull/917#issuecomment-1546877424
In this comment, you mentioned setting stream limit to -1 in order to apply no limit. But MaxAge value expecting time.Duration type.
https://github.com/memphisdev/memphis/blob/master/server/memphis_helper.go#L242C6-L242C6
Can we set this MaxAge to time.Duration(math.MaxInt64) which provides a value of 292 years.
@Big-Vi May I suggest a different task? Since you are an expert in Schemaverse, what do you think about making more progress there? For example: https://github.com/memphisdev/memphis/issues/879 (Huge impact) https://github.com/memphisdev/memphis/issues/723 https://github.com/memphisdev/memphis/issues/485
@yanivbh1 I can pick one and work on it.
Hey @Big-Vi , #879 would be a huge win.