use supermemory graph package
-
#595
π (View in Graphite)
-
main
How to use the Graphite Merge Queue
Add the label Main to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.
An organization admin has enabled the Graphite Merge Queue in this repository.
Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Deploying with Β
Β Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| β Deployment failed View logs |
supermemory-app | 59823afb | Dec 03 2025, 05:33 PM |
Code Review: Use Supermemory Graph Package
Summary
This PR successfully extracts the memory graph visualization code from packages/ui/memory-graph into a standalone package @supermemory/memory-graph, significantly reducing code duplication and improving maintainability. The PR shows 23 additions and 3,980 deletions, indicating a major cleanup effort.
β Strengths
-
Excellent Code Organization
- Successfully extracts ~4,000 lines of duplicated code into a dedicated package
- The new package is properly structured as a workspace package with correct package.json configuration
- Clean separation of concerns - colors extracted to @repo/ui/colors for shared use
-
Minimal Breaking Changes
- All import paths updated correctly across the codebase
- Changed from @repo/ui/memory-graph to @supermemory/memory-graph
- Changed from @repo/ui/memory-graph/constants to @repo/ui/colors
- All 8 affected files updated consistently
-
Package Quality
- Good package metadata with proper exports, types, and build configuration
- Peer dependencies correctly specified (react >= 18.0.0)
- Uses modern tooling (Vite, TypeScript, Vanilla Extract)
- Proper workspace:* protocol for monorepo dependencies
π Observations & Minor Concerns
-
Dependency Updates in bun.lock
- Lock file shows version bumps for several dependencies (framer-motion, @tanstack/react-query, tailwindcss, etc.)
- These appear to be automatic updates during the package reorganization
- Should verify these do not introduce breaking changes (though likely safe)
-
Colors File Location
- colors.ts moved from packages/ui/memory-graph/constants.ts to packages/ui/colors.ts
- Only the color constants were kept; layout/graph constants removed (presumably now in the new package)
- This is good - colors are UI-level concerns, graph logic is component-level
-
Build Process
- The new package has proper build scripts (vite build && tsc --emitDeclarationOnly)
- Consider verifying the build works in packages/memory-graph
π― Recommendations
-
Testing
- Verify types across the monorepo with: bun run check-types
- Build the web app to ensure no import issues
- Test the graph functionality in the development environment
-
Documentation
- The package appears to have a README
- Ensure it documents the API, props, and usage examples
- Add migration guide if this is being published to npm
-
Version Bump Consideration
- Package is at v0.1.1 - consider if this refactor warrants a version bump
- If publishing publicly, ensure proper semver practices
π Security
- No security concerns identified
- Standard React component package with visualization logic
- No external API calls or data handling in the changed code
β‘ Performance
Moving to a dedicated package should improve:
- Build times (better caching boundaries)
- Tree-shaking (clearer dependency boundaries)
- Code splitting in the consuming apps
π Code Quality
Excellent - This is a textbook example of extracting a reusable component into a package. Follows monorepo best practices with clean dependency management and consistent code style.
β Approval Status
APPROVED - This is a well-executed refactoring that significantly improves code organization. The changes are mechanical, consistent, and low-risk.
Suggested next steps:
- Verify builds pass
- Test the graph visualization in the web app works correctly
- Merge when checks are green
Great work on reducing technical debt! π
lets get the new version published, then i'll fix this
Merge activity
- Dec 3, 6:25 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
- Dec 3, 6:25 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..