aframe-watcher icon indicating copy to clipboard operation
aframe-watcher copied to clipboard

CTRL-C will now exit the program

Open Luk164 opened this issue 3 years ago • 6 comments

Just a simple piece of code added to the end of the file + two booleans to check if files are being written to. Also does not allow files to be written while shutting down and will automatically reject incoming connections. Relates to issue https://github.com/supermedium/aframe-watcher/issues/13

Luk164 avatar Apr 02 '21 16:04 Luk164

I tested this PR but it isn't working for me. If don't save any changes it shutdows with Ctrl-C. But after I have saved any change in the scene Ctrl-C no longer works

Juankz avatar Jul 27 '21 03:07 Juankz

Update: Seems to be a problem with the package prompt-confirm capturing the input and not reporting the SIGINT signal. See https://github.com/enquirer/prompt-confirm/issues/9

Juankz avatar Jul 27 '21 04:07 Juankz

@Juankz That repo seems to be dead, I dont really know how to proceed here

Luk164 avatar Aug 02 '21 13:08 Luk164

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

Juankz avatar Aug 02 '21 19:08 Juankz

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

I do not see any PRs from your account there, could you drop a link?

Luk164 avatar Aug 03 '21 10:08 Luk164

Sure https://github.com/supermedium/aframe-watcher/pull/20

Juankz avatar Aug 03 '21 14:08 Juankz