super_editor icon indicating copy to clipboard operation
super_editor copied to clipboard
verified publisher icon superlistapp

Fix toggling debug info crashing the editor

Open knopp opened this issue 1 year ago • 4 comments

Fixes https://github.com/superlistapp/super_editor/issues/2254

  • Changes Stack in SuperEditorImeDebugVisuals to SliverHybridStack because the render object now lives in a sliver
  • Implements forgetChild inside ContentLayersElement. This is necessary because the content of ContentLayersElement is being reparented using GlobalKey so it needs to be excluded from visitChildren when unmounting.

knopp avatar Aug 19 '24 07:08 knopp

@knopp are you still working on this, or do you think you responded to all my comments? Whenever you do, please re-request a review so that I'm notified.

matthew-carroll avatar Aug 26 '24 23:08 matthew-carroll

I added missing comments.

knopp avatar Aug 27 '24 17:08 knopp

@knopp I don't see any code comments in the change log

matthew-carroll avatar Sep 14 '24 17:09 matthew-carroll

@knopp I don't see any code comments in the change log

That's because I forgot to actually push the changes :) Sorry about it. Should be there now.

knopp avatar Sep 14 '24 21:09 knopp

@knopp can you give this PR another pass for comments?

matthew-carroll avatar Oct 18 '24 19:10 matthew-carroll

@matthew-carroll, let me know if this is any better.

knopp avatar Nov 06 '24 20:11 knopp

@angelosilvestre can you cherry pick this?

matthew-carroll avatar Nov 09 '24 01:11 matthew-carroll