superlistapp
[FEATURE] - Allow vertical scrolling of a multi-line SuperTextField when its text overflows
Your Info Using SuperEditor at Superlist
User Behavior Multi-line SuperTextFields with text that overflow (e.g. 3 lines of text, when max lines is 2) are not vertically scrollable on mobile. I can confirm this is not an issue on desktop (at least I tested on macOS).
Feature Value It would be great if we could vertically scroll up and down within the text field to access the overflowed text content.
Additional context To work around this, you can initiate the magnifier and then vertically scroll, but this seems like it should be possible without this workaround.
For context, here is the desired behaviour visible in iMessage on iOS:
https://github.com/superlistapp/super_editor/assets/5852503/67bef542-c426-43e1-92ad-f15778620879
Here is a demo showing iOS scrolling is not possible, but macOS is:
https://github.com/superlistapp/super_editor/assets/5852503/561d19be-b230-4961-81d0-c19cc41fbb1b
I was able to make a change that seems to fix it:
- changing a
NeverScrollableScrollPhysicstonull - when it's a multi-line SuperTextfield on mobile
- which ends up being a suitable scroll physics for the platform
https://github.com/superlistapp/super_editor/assets/5852503/f21e63c7-8ff5-4623-9da7-56564cc75fd7
I put this change into a PR for your consideration: https://github.com/superlistapp/super_editor/pull/2139
Please note that I checked existing tests did not break, and tried to add tests for this new functionality, but could not get the mobile variants to pass. I'm not sure what I did wrong in the tests, if they are in the right files, or even if they are the tests you would want. Let me know what you think, and how would be best to proceed.