supergrub icon indicating copy to clipboard operation
supergrub copied to clipboard

Published 20 hours ago • verified publisher icon supergrub

Show boot mode in main menu #58

Open mk-pmb opened this issue 4 years ago • 4 comments

Fixes #58

mk-pmb avatar Jan 09 '20 02:01 mk-pmb

What's left to do?

mk-pmb avatar Jan 28 '20 18:01 mk-pmb

What's left to do?

As I said in the original issue I want to integrate this functionality myself into SG2D because of the upcoming Secure Boot integration.

There are two concerns about this functionality that I have myself while planning to implement it in the future:

  • The Secure Boot integration (Not only showing if UEFI SecureBoot is on but also if it's the Debian one or the Ubuntu one).
  • The variable should be only set once when SG2D main menu is loaded for the first time (not every time the main menu is loaded).

Now that I check your commit you are adding it on an option (Boot manually). My implementation would add it as a main menu title or as a main menu subtitle.

However I encouraged in the former issue to implement it so that I did not have to implement it from scratch. So thank you.

adrian15 avatar Jan 30 '20 00:01 adrian15

Depending on how long you take for your version, could you maybe merge this one and later replace it? That way I wouldn't need to re-merge it in my version each time I pull your master.

mk-pmb avatar Jan 30 '20 03:01 mk-pmb

Any news on this?

mk-pmb avatar Jun 09 '20 02:06 mk-pmb