control icon indicating copy to clipboard operation
control copied to clipboard

2.0.1: SG UI - <h1> font-family incorrectly assigned in Safari 12.0.3

Open hetmanchuk opened this issue 5 years ago • 5 comments

Short Summary: Font weight is not as in design.

Steps to Reproduce: Look at any H1 header (Montserrat font face)

Expected Results: image

https://xd.adobe.com/spec/3c5108bd-fd7f-467f-47f8-837ef0d07611-4a60/screen/897f010a-685e-4713-b0ba-19ec6b94f774/sg2-home-v3-no-accounts/

Actual Results: image

hetmanchuk avatar Jan 30 '19 12:01 hetmanchuk

@hetmanchuk it looks like this hasn't changed in the app for quite a while now (https://github.com/supergiant/control/blob/120e4590b8e3343bf96f436edc6d9d4183c17d0b/cmd/ui/assets/src/assets/css/supergiant-material.scss#L72). Did we just miss this during the last round of QA? Regardless, do you know what the font weight value should be? I seem to remember there being a rendering discrepancy between google fonts and xD...

josephkane avatar Feb 01 '19 21:02 josephkane

I remember that I personally changed all fonts with 100/200 weights to 300, and it worked perfectly in all toolkit. Here is that issue: https://github.com/supergiant/control/issues/1140

And this screenshot I've took from screenshots on Medium, perhaps Kirill overwrite it manually? Let me check all toolkit UI again. @josephkane @nikage

hetmanchuk avatar Feb 04 '19 14:02 hetmanchuk

this was a problem with a screenshot, not app

josephkane avatar Feb 04 '19 16:02 josephkane

ok, let's open it again @josephkane

hetmanchuk avatar Feb 04 '19 17:02 hetmanchuk

Reopening and renaming: this looks to be a bug caught by @golkir's Safari (v12.0.3), currently working to reproduce.

Google font is loading fine, but sans-serif is activated instead of Montserrat

josephkane avatar Feb 04 '19 17:02 josephkane